Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX]correcting cuda 11.2 image name in CI and CD #19960

Merged
merged 1 commit into from
Feb 26, 2021
Merged

[BUGFIX]correcting cuda 11.2 image name in CI and CD #19960

merged 1 commit into from
Feb 26, 2021

Conversation

access2rohit
Copy link
Contributor

@access2rohit access2rohit commented Feb 26, 2021 •
edited
Loading

Description

corrects the name of CUDA 11.2 nvidia containers introduced in PR #19930
Correct names taken from here: https://hub.docker.com/r/nvidia/cuda

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@mxnet-bot
Copy link

Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, centos-gpu, windows-cpu, unix-gpu, unix-cpu, miscellaneous, sanity, edge, centos-cpu, windows-gpu, clang]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Feb 26, 2021
@access2rohit
Copy link
Contributor Author

@Zha0q1 its ready for review

Zha0q1
Zha0q1 approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@lanking520 lanking520 added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 26, 2021
@Zha0q1 Zha0q1 merged commit a9eec24 into apache:v1.x Feb 26, 2021
access2rohit added a commit to access2rohit/incubator-mxnet that referenced this pull request Mar 9, 2021
@access2rohit
correcting cuda 11.2 image name in CI and CD (apache#19960)
e16818d 
Co-authored-by: Rohit Kumar Srivastava <[email protected]>
access2rohit added a commit to access2rohit/incubator-mxnet that referenced this pull request Mar 10, 2021
@access2rohit
correcting cuda 11.2 image name in CI and CD (apache#19960)
f445ec9 
Co-authored-by: Rohit Kumar Srivastava <[email protected]>
access2rohit added a commit to access2rohit/incubator-mxnet that referenced this pull request Mar 10, 2021
@access2rohit
correcting cuda 11.2 image name in CI and CD (apache#19960)
45e6249 
Co-authored-by: Rohit Kumar Srivastava <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zha0q1 Zha0q1 Zha0q1 approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@access2rohit @mxnet-bot @Zha0q1 @lanking520